tools: remove targets for individual test suites in Makefile#46892
tools: remove targets for individual test suites in Makefile#46892nodejs-github-bot merged 2 commits intonodejs:mainfrom
Makefile#46892Conversation
nodejs-github-bot
added
build
github-actions
bot
removed
the
request-ci
richardlau
changed the title
MakefileMakefile
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
I've doubled checked and AFAICT nothing in our CI is using any of the removed targets. To err on the safe side, I've added "dont-land-` labels in case any downstream consumers/repackagers are using these targets in their scripts.
aduh95
added
dont-land-on-v19.x
author ready
cc @nodejs/distros |
| $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=debug | ||
|
|
||
| .PHONY: test-message | ||
| test-message: test-build |
There was a problem hiding this comment.
This target and the ones below that are being removed are also present in vcbuild.bat. Might be worth removing these from there too?
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Let's make sure we remove the same things in the vcbuild.bat file too. (Once that's done, feel free to dismiss this review. No need to wait for me to do it.)
aduh95
added
commit-queue
github-actions
bot
removed
the
request-ci
richardlau
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 553b052 |
6 participants
I find those target not very useful (instead of typing
make test-message, it's as easy to typetools/test.py test/messageIMO), and sometimes their name is confusing (e.g. sometimes folks would confusemake test-parallelfor running the tests in parallel, while in fact it's running – sequentially by default – thetest/paralleltest suite).wdyt?